Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxutil: BlitzMaxPath scans CurrentDir for BMK too #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GWRon
Copy link
Contributor

@GWRon GWRon commented Nov 12, 2014

  • changed BlitzMaxPath() to scan AppDir and CurrentDir, this allows BMK to be a symlinked binary
  • kept "path + bin/bmk" to avoid registering the CurrentDir() as BlitzMax path just because it contains a "bmk[.exe]" file. Maybe it is better to check for more than just "this file" to accept it as "BlitzMax"-Path)

@woollybah
Feel free to NOT accept this pull request - it is not needed for everyone (but you know, cleaner working directories might help during development). If you want to have the ability to run "bmk makemods" from your individual directory, while the environment variable is set to another BlitzMax-directory then we should change order of checks to this:

  • currentDir
  • environment
  • appDir

So we could run it from our individual directory without modifying system wide variables or other things.

- changed BlitzMaxPath() to scan AppDir and CurrentDir, this allows BMK to be a symlinked binary
- kept "path + bin/bmk" to avoid registering the CurrentDir() as BlitzMax path just because it contains a "bmk[.exe]" file. Maybe it is better to check for more than just "this file" to accept it as "BlitzMax"-Path)
@GWRon
Copy link
Contributor Author

GWRon commented Mar 19, 2015

Thoughts? Decline? Accept?

@GWRon
Copy link
Contributor Author

GWRon commented Jun 16, 2019

Slightly related to:
bmx-ng/bmk#86

@GWRon
Copy link
Contributor Author

GWRon commented Aug 6, 2019

Is there as reason speaking against this change?
Decline if you do not want this change.
Blame if you do not like the approach/code style.
Accept if it is ok to have it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant