Skip to content

Commit

Permalink
🐛 fixed #24 thanks @afbora
Browse files Browse the repository at this point in the history
⬆️ upgraded dependencies

Signed-off-by: bnomei <[email protected]>
  • Loading branch information
bnomei committed Oct 16, 2022
1 parent 17c8d26 commit cf1a4a3
Show file tree
Hide file tree
Showing 25 changed files with 916 additions and 945 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '7.3'
php-version: '8.0'
tools: composer

- name: Install
Expand Down
2 changes: 1 addition & 1 deletion .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

return (new PhpCsFixer\Config())
->setRules([
'@PSR2' => true,
'@PSR12' => true,
])
->setFinder($finder)
;
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
language: php
php: 7.3
php: 8.0
matrix:
fast_finish: true
install: composer install --no-interaction
Expand Down
2 changes: 1 addition & 1 deletion classes/Handlebars.php
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ public function renderCacheId()
* @param string $result
* @return bool
*/
public function write(?string $renderCacheId = null, string $result): bool
public function write(?string $renderCacheId = null, ?string $result = null): bool
{
if ($renderCacheId && $this->option('render')) {
return kirby()->cache('bnomei.handlebars.render')->set($renderCacheId, $result);
Expand Down
1 change: 1 addition & 0 deletions classes/HandlebarsData.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

declare(strict_types=1);

namespace Bnomei;
Expand Down
9 changes: 6 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "bnomei/kirby3-handlebars",
"type": "kirby-plugin",
"version": "3.5.0",
"version": "3.6.0",
"license": "MIT",
"description": "Kirby 3 Component for semantic templates with Handlebars and Mustache",
"authors": [
Expand Down Expand Up @@ -39,10 +39,13 @@
},
"config": {
"optimize-autoloader": true,
"sort-packages": true
"sort-packages": true,
"allow-plugins": {
"getkirby/composer-installer": true
}
},
"require": {
"php": ">=7.3.0",
"php": ">=8.0",
"getkirby/composer-installer": "^1.2",
"zordius/lightncandy": "1.2.2"
},
Expand Down
Loading

0 comments on commit cf1a4a3

Please sign in to comment.