Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip creation of arguments object if possible #4087

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 15, 2024

This Pull Request changes the following:

  • Skip creation of arguments object if possible

This seems to increase the peformance in some benchmarks significantly:

Before:

RESULT Richards 55.9
RESULT DeltaBlue 49.1
RESULT Crypto 82.7
RESULT RayTrace 152
RESULT EarleyBoyer 180
RESULT RegExp 41.9
RESULT Splay 216
RESULT NavierStokes 186
SCORE 100

After:

RESULT Richards 72.0
RESULT DeltaBlue 67.6
RESULT Crypto 85.9
RESULT RayTrace 174
RESULT EarleyBoyer 219
RESULT RegExp 42.0
RESULT Splay 305
RESULT NavierStokes 186
SCORE 118

@raskad raskad added the execution Issues or PRs related to code execution label Dec 15, 2024
@raskad raskad added this to the next-release milestone Dec 15, 2024
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,625 48,625 0
Passed 43,616 43,616 0
Ignored 1,471 1,471 0
Failed 3,538 3,538 0
Panics 0 0 0
Conformance 89.70% 89.70% 0.00%

@raskad raskad requested a review from a team December 15, 2024 04:30
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@hansl hansl enabled auto-merge December 15, 2024 22:45
@raskad raskad requested a review from a team December 15, 2024 23:29
@nekevss nekevss requested a review from a team December 19, 2024 18:57
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hansl hansl added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit d870057 Dec 19, 2024
13 checks passed
@hansl hansl deleted the arguments-object-skip branch December 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants