Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'shift' keycode instead of numeric code #11

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

ChrisC
Copy link
Contributor

@ChrisC ChrisC commented Aug 27, 2024

This is a partial fix for a bug that affected the ability to navigate backwards through a document using SHIFT+TAB keys on MacOS.

The ability to navigate backwards using "Single-Key Quick Nav" (which also uses the SHIFT key) is still broken. I would recommend that we merge this partial fix, add some regression testing for our applescript output, and then come back to the Single-Key Quick Nav issue once some more reliable testing is in place for our applescript generators.

This fixes a bug that affected the ability to navigate backwards through a document using SHIFT+TAB keys
@jugglinmike
Copy link
Member

Hey @ChrisC! I functionally verified this with the following command:

node aria-at-automation-harness/bin/host.js run-plan \
  --plan-workingdir aria-at/build/tests/horizontal-slider '{reference/**,test-06-*-voiceover_macos.*}' \
  --web-driver-url=http://127.0.0.1:4444 \
  --at-driver-url=ws://127.0.0.1:4382/session \
  --reference-hostname=127.0.0.1 \
  --web-driver-browser=safari > ./harness-run.log

A unit test was failing, so I fixed that. I also added a comment about the key code to make the rationale a little more discoverable than git blame. Let me know if those changes look good to you, and I'll be happy to merge this.

@ChrisC
Copy link
Contributor Author

ChrisC commented Aug 29, 2024

Hey @ChrisC! I functionally verified this with the following command:

node aria-at-automation-harness/bin/host.js run-plan \
  --plan-workingdir aria-at/build/tests/horizontal-slider '{reference/**,test-06-*-voiceover_macos.*}' \
  --web-driver-url=http://127.0.0.1:4444 \
  --at-driver-url=ws://127.0.0.1:4382/session \
  --reference-hostname=127.0.0.1 \
  --web-driver-browser=safari > ./harness-run.log

A unit test was failing, so I fixed that. I also added a comment about the key code to make the rationale a little more discoverable than git blame. Let me know if those changes look good to you, and I'll be happy to merge this.

Looks good! Feel free to merge

@jugglinmike jugglinmike merged commit 0b1929f into main Aug 29, 2024
8 checks passed
@jugglinmike jugglinmike deleted the fix-shift-key-macos branch August 29, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants