Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added mzML formats and type #2

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Nov 27, 2024

closes #1
depends on #5

  • Adds mzMLFormat, mzMLDirFmt and SampleData[mzML]

Run it locally

  1. First, clone the repo and checkout the PR branch:
git clone https://github.com/bokulich-lab/q2-ms.git
cd q2-ms
git fetch origin pull/2/head:pr-2
git checkout pr-2
pip install -e .
  1. Download test files
    PR-1-ms.zip

  2. Test it out!

qiime tools import --input-path PR-1-ms --output-path mzML.qza --type "SampleData[mzML]"

@misialq
Copy link

misialq commented Jan 14, 2025

Hey @VinzentRisch, before I review this (and the other PR), would you mind merging #5 and rebasing both PRs? It would be easier to review - thanks! 🙏

Copy link

@VinzentRisch
Copy link
Collaborator Author

Hi @misialq
I merged the other PR.

Copy link

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌

q2_ms/types/__init__.py Outdated Show resolved Hide resolved
@VinzentRisch VinzentRisch merged commit b9045d0 into bokulich-lab:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add format for mzML files.
2 participants