Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 4.x deprecations #2410

Merged
merged 4 commits into from
Apr 4, 2021
Merged

Remove 4.x deprecations #2410

merged 4 commits into from
Apr 4, 2021

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Feb 18, 2021 •
edited
Loading

If this is accepted, we need to fix bolt/newswidget#6

@I-Valchev I-Valchev changed the base branch from master to 4.1 February 24, 2021 12:23
@I-Valchev I-Valchev changed the base branch from 4.1 to master February 24, 2021 12:23
@I-Valchev I-Valchev changed the base branch from master to 4.1 February 24, 2021 15:52
@I-Valchev I-Valchev changed the base branch from 4.1 to master February 24, 2021 15:52
@I-Valchev I-Valchev changed the base branch from master to 4.1 February 25, 2021 08:05
@I-Valchev I-Valchev changed the base branch from 4.1 to master February 25, 2021 08:05
bobdenotter
bobdenotter approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@I-Valchev I-Valchev changed the base branch from master to 4.1 March 2, 2021 14:21
@I-Valchev I-Valchev changed the base branch from 4.1 to master March 2, 2021 14:21
@I-Valchev
Copy link
Member Author

@bobdenotter I really don't know why this is failing, can we take a look at it together? 🤔

@bobdenotter
Copy link
Member

All fixed up! 🛠️

@bobdenotter bobdenotter merged commit 0e7ba21 into master Apr 4, 2021
@bobdenotter bobdenotter deleted the refactor/remove-deprecations branch April 4, 2021 14:13
@I-Valchev
Copy link
Member Author

Nice, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🧹 Chore 🎩 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter