Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Ownership Requirements for piprm. #446

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Relax Ownership Requirements for piprm. #446

merged 1 commit into from
Jul 28, 2023

Conversation

gatoWololo
Copy link

@marsella I'm less confident about how this PR turned out. Lmk what you think. (See my comments below)

@gatoWololo gatoWololo requested a review from marsella July 18, 2023 23:41
marsella
marsella approved these changes Jul 20, 2023
View reviewed changes
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please re-request a review if you decide to change the verify API.

src/auxinfo/auxinfo_commit.rs Show resolved Hide resolved
src/zkp/piprm.rs Show resolved Hide resolved
@gatoWololo gatoWololo merged commit 2383ae0 into main Jul 28, 2023
2 checks passed
@gatoWololo gatoWololo deleted the 400-ownership-piprm branch July 28, 2023 23:42
@gatoWololo gatoWololo mentioned this pull request Jul 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsella marsella marsella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatoWololo @marsella