Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove non-failure error from pimod #457

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

marsella
Copy link

Closes #419

There are more issues to fix here, I think, in terms of code quality, but this should fix the specific "spam the error logs" problem we've seen. Before I close this I will write another issue with some more specifics.

@marsella marsella requested a review from hridambasu July 27, 2023 21:16
src/zkp/pimod.rs Show resolved Hide resolved
src/zkp/pimod.rs Show resolved Hide resolved
Copy link

@hridambasu hridambasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@marsella marsella merged commit d1e6962 into main Jul 31, 2023
2 checks passed
@marsella marsella deleted the 419-fix-error-handling-pimod branch July 31, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish Error PiMod
2 participants