113 pifac tests

[hridambasu]

Closes #113

[marsella]

Some minor nits on this test.

You noted that some tests already exist but they are actually not complete as is. There's some discussion and checklists in the comments of #113. Please add the missing pieces noted there, and double check whether anything else is also missing.

[marsella]

Thanks for adding some additional tests. There are still a few things missing that are noted in the comments on the original issue:

• The test_no_small_factors_proof_negative_cases needs to be broken into smaller tests. The monolithic thing is hard to read and hard to know what's being tested and there's no reason for it to be one giant test full of independent assertions.
• Many of the pre-existing tests are not testing what they claim to be testing. Many assertions are failing because the test is being proved and verified with different common inputs, but the comments suggest that the tests are validating properties on the secret inputs. These need to be fixed or removed.

[hridambasu]

@marsella Fixed all your comments. Didn't notice any check related to common input in stead of secret input. If you do notice, please let me know and I'll fix them.

[marsella]

Didn't notice any check related to common input in stead of secret input. If you do notice, please let me know and I'll fix them.

I made a separate issue #465 to address my remaining concern.

In a call a while ago, we talked about documenting test_modulus_cannot_have_large_factors to explain how the range check in the proof looks for "too large", not "too small", despite the name of the proof. This needs to be captured somewhere before this can be merged.

Otherwise looks good.

[marsella]

@hridambasu Please write documentation about the range check in the proof either in the original testing issue (to close the loop) or in the documentation for the proof in the code. Then I will approve.

[hridambasu]

@marsella I documented this in the original issue.