Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

116 AuxInfo Tests #472

Merged
merged 19 commits into from
Sep 25, 2023
Merged

116 AuxInfo Tests #472

merged 19 commits into from
Sep 25, 2023

Conversation

hridambasu
Copy link

Closes #116

@hridambasu hridambasu changed the title AuxInfo Tests 116 AuxInfo Tests Aug 21, 2023
marsella
marsella suggested changes Aug 21, 2023
View reviewed changes
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the goal of these tests should be to make sure that the AuxInfoProof::{prove, verify} APIs work correctly. I realize that wasn't super clear from the issue description. I've made some suggestions inline on how to do that.

src/auxinfo/proof.rs Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/protocol.rs Outdated Show resolved Hide resolved
marsella
marsella suggested changes Sep 11, 2023
View reviewed changes
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the CommonInput type. Have a few suggestions for integrating it better into the existing infra.

src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Show resolved Hide resolved
src/auxinfo/proof.rs Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
marsella
marsella suggested changes Sep 20, 2023
View reviewed changes
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, just a few small clean-up tasks.

src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
marsella
marsella reviewed Sep 21, 2023
View reviewed changes
src/auxinfo/proof.rs Outdated Show resolved Hide resolved
marsella
marsella approved these changes Sep 25, 2023
View reviewed changes
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one small change remaining -- please address it before closing that comment and merging.

Otherwise looks good!

@hridambasu hridambasu merged commit 0b4bdb9 into main Sep 25, 2023
2 checks passed
@hridambasu hridambasu deleted the 116-new-auxinfo-tests branch September 25, 2023 15:17
@marsella marsella mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsella marsella marsella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write tests for AuxInfoProof
2 participants
@hridambasu @marsella