Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

410 Add identifiable abort ids to Protocol errors #480

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

hridambasu
Copy link

Closes #410

@hridambasu hridambasu requested a review from marsella August 24, 2023 11:02
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we'll have to figure out how to throw protocol failures correctly from ZK proof validation. Realistically, if a proof fails to verify it's the sender's fault and we already know that (even for proofs in presign). But the proofs don't know who their sender is. We might need to change the way we do error handling when proof validation fails so that we can augment protocol errors with the sender PID (e.g. we might want a separate error enum for "internal cryptography" modules, including paillier, ZKPs, curve points, etc., that we have to convert at the call site to a meaningful external-facing error). cc @gatoWololo.

I actually see a couple of follow-up issues that should come out of this:

  • Handle the actual identifiable cases in presign (the output round requires additional work to identify a cheater, but earlier rounds can do it with our current information)
  • Redesign errors for ZKP module (or cryptography more broadly) so we can assign blame at the calling level
  • Eventually, design + implement identifiable abort for the presign and sign output rounds.
  • Add a warning to the README that explains that we do not have identifiable abort fully implemented at this time.

I'll write these up shortly.

src/auxinfo/auxinfo_commit.rs Outdated Show resolved Hide resolved
src/auxinfo/auxinfo_commit.rs Outdated Show resolved Hide resolved
src/auxinfo/auxinfo_commit.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/participant.rs Outdated Show resolved Hide resolved
@marsella
Copy link

I made an epic #486 with some of the issues above in it. So now we have a placeholder for these changes.

Another note on this PR: I think we should add a note to the README to explain the current state of ID abort -- that is, we sometimes report blame when it's easy to assign, but we miss many cases and users should not rely on that field to be complete at this time.

@hridambasu hridambasu force-pushed the 410-id-abort-errors branch from bf65adb to adc68ca Compare October 3, 2023 13:23
@hridambasu hridambasu force-pushed the 410-id-abort-errors branch from adc68ca to b7f3fb4 Compare October 3, 2023 15:20
Copy link

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look great!

There's some extraneous code from another PR that needs to get removed before this can be merged. Please take out those lines.

src/auxinfo/auxinfo_commit.rs Outdated Show resolved Hide resolved
@hridambasu hridambasu merged commit 322d2e2 into main Oct 5, 2023
@hridambasu hridambasu deleted the 410-id-abort-errors branch October 5, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add identifiable abort ids to protocol errors
2 participants