Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest version of redoc cli #164

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

benjaminParisel
Copy link
Contributor

@benjaminParisel benjaminParisel commented Apr 12, 2024

On this day, the unpk.com provider was down for a few hours. During this time, our bonita-openapi search was broken.

To avoid similar issue in the future, we remove a usage a deprecated version of redoc-cli and use the "new" library -> "@redocly/cli".

Before this PR, when we use the redoc-cli, we got this line in the index.html

<script src="https://unpkg.com/redoc@latest/bundles/redoc.standalone.js"></script><style data-styled="true" data-styled-version="5.3.0">.juinod{width:calc(100% - 40%);padding:0 40px;}/*!sc*/

But this unpkg link are down since this morning and the searchbar on this documentation are broken.

With this PR, we load this library in another cdn: <script src="https://cdn.redoc.ly/redoc/v2.1.3/bundles/redoc.standalone.js"></script>

Copy link

github-actions bot commented Apr 12, 2024

🎊 PR Preview 8b46778 has been successfully built and deployed to https://bonitasoft-bonita-openapi-deployPreview-pr-164.surge.sh

🕐 Build time: 0.009s

🤖 By surge-preview

@benjaminParisel
Copy link
Contributor Author

Before this PR, when we use the redoc-cli, we got this line in the index.html

<script src="https://unpkg.com/redoc@latest/bundles/redoc.standalone.js"></script><style data-styled="true" data-styled-version="5.3.0">.juinod{width:calc(100% - 40%);padding:0 40px;}/*!sc*/

But this unpkg link are down since this morning and the searchbar on this documentation are broken.

With this PR, we load this library in another cdn: <script src="https://cdn.redoc.ly/redoc/v2.1.3/bundles/redoc.standalone.js"></script>

@benjaminParisel benjaminParisel marked this pull request as ready for review May 22, 2024 08:22
@benjaminParisel benjaminParisel requested a review from tbouffard May 22, 2024 08:22
@akantcheff akantcheff force-pushed the feat/use_latest_redoc_cli branch from da65016 to ce13921 Compare May 23, 2024 13:46
@akantcheff akantcheff force-pushed the feat/use_latest_redoc_cli branch from ce13921 to 8b46778 Compare May 23, 2024 13:56
@akantcheff akantcheff merged commit 2ad978a into master May 23, 2024
3 checks passed
@akantcheff akantcheff deleted the feat/use_latest_redoc_cli branch May 23, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants