Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application): Update REST API for advanced applications. #168

Merged
merged 4 commits into from
May 21, 2024

Conversation

vhemery
Copy link
Contributor

@vhemery vhemery commented May 14, 2024

Relates to BPM-94

Copy link

github-actions bot commented May 14, 2024

🎊 PR Preview 576543c has been successfully built and deployed to https://bonitasoft-bonita-openapi-deployPreview-pr-168.surge.sh

🕐 Build time: 0.009s

🤖 By surge-preview

Copy link
Contributor

@jeromecambon jeromecambon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I didn't see how to display the advanced application example

@vhemery
Copy link
Contributor Author

vhemery commented May 17, 2024

LGTM! I didn't see how to display the advanced application example

REST_API

Copy link
Contributor

@jeromecambon jeromecambon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The examples (in the right pane) are not working as expected
  • Version of the API should be incremented

@jeromecambon
Copy link
Contributor

jeromecambon commented May 17, 2024

LGTM! I didn't see how to display the advanced application example

Thanks for the video, but this is not what I meant, I am speaking about the examples in the right panel

@vhemery
Copy link
Contributor Author

vhemery commented May 17, 2024

The array example can't use references to different schema locations, so I had to copy values in it.

@vhemery vhemery force-pushed the feat/BPM-94-update_rest_api branch from 0a1d436 to 576543c Compare May 17, 2024 15:59
@vhemery vhemery requested a review from jeromecambon May 17, 2024 15:59
@vhemery
Copy link
Contributor Author

vhemery commented May 17, 2024

Note:
Deprecated enpoints use the legacy application.

This is not an error !

Copy link
Contributor

@jeromecambon jeromecambon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromecambon jeromecambon merged commit 9c9c698 into master May 21, 2024
3 checks passed
@jeromecambon jeromecambon deleted the feat/BPM-94-update_rest_api branch May 21, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants