Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): explain how to configure and retrieve a license #10

Merged
merged 9 commits into from
Aug 13, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jul 4, 2024

Tasks

Closes https://bonitasoft.atlassian.net/browse/BON-367

Copy link

github-actions bot commented Jul 4, 2024

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

@bonita-ci
Copy link

bonita-ci commented Jul 4, 2024

🎊 PR Preview 6be9df2 has been successfully built and deployed to https://bonitasoft-bonita-process-insights-doc-deploy-pr-10.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@@ -6,6 +6,16 @@ A Command Line Interface tool (CLI) is used to provision data extracted from Bon

The command line tool is delivered as a package, containing a basic documentation about commands and a sample configuration file.


== BPI license
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is taken from the cli distribution

Copy link
Member Author

@tbouffard tbouffard Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: if you don't like the "square" that tries to highlight the element in the menu, we can use the original screenshot 👇🏿
We should probably remove the footer. What do you think about this @Yves-Jacq?

Notice that current screenshot is not consistent with the recent screenshots added to other pages of the documentation. They don't display the footer (which includes the Bonitasoft copyright).

generate_license_raw

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbouffard the footer must be present everywhere

tbouffard added 4 commits July 5, 2024 09:57
# Conflicts:
#	modules/cli/pages/index.adoc
# Conflicts:
#	modules/application/taxonomy.adoc
#	modules/cli/pages/index.adoc
@tbouffard
Copy link
Member Author

@Yves-Jacq I have just integrated your feedback.
Can you tell me if this is now OK?

@tbouffard tbouffard marked this pull request as ready for review August 13, 2024 11:49
Copy link
Contributor

@Yves-Jacq Yves-Jacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

Copy link
Contributor

@Yves-Jacq Yves-Jacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@tbouffard tbouffard requested a review from uguy August 13, 2024 14:52
@tbouffard tbouffard merged commit 22ccd90 into main Aug 13, 2024
5 checks passed
@tbouffard tbouffard deleted the feat/cli_license branch August 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants