Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pi-cli): Add the anonymization documentation #3

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

mbource
Copy link
Contributor

@mbource mbource commented May 31, 2024

Add the anonymization documentation for the export tool PI-CLI.

Covers https://bonitasoft.atlassian.net/browse/BON-337

Copy link

github-actions bot commented May 31, 2024

🎊 PR Preview 23d52ef has been successfully built and deployed to https://bonitasoft-bonita-process-insights-doc-build_preview-pr-3.surge.sh

🕐 Build time: 0.008s

🤖 By surge-preview

Copy link

github-actions bot commented May 31, 2024

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

@mbource mbource changed the title Add the anonymization documentation docs(pi-cli): Add the anonymization documentation May 31, 2024
@mbource mbource marked this pull request as draft May 31, 2024 12:55
@mbource mbource marked this pull request as ready for review June 5, 2024 14:56
Copy link

github-actions bot commented Jun 6, 2024

🎊 PR Preview 4257612 has been successfully built and deployed to https://bonitasoft-bonita-process-insights-doc-deploy-pr-3.surge.sh

🕐 Build time: 0.008s

🤖 By surge-preview

Comment on lines 17 to 23
database:
host: localhost
port: 5432
name: bonita
username: bonita
password: bpm
jdbc-url: myJdbcUrl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: can we avoid to duplicate the documentation here and mention that this is available in the documentation embeeded in the distribution?
This risks to be a maintenance issue if we duplicate the content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove the configuration sample part to avoid duplication/maintenance changes. I did keep the jdbc url explanation for the different database, should I remove it too?

Remove the whole data line ( only possible on data contract and comment )

*Parameters* :
optional where clause expressed as a regex to match with the value for the configured column.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: the where clause applies to all actions, so we could document it and give examples in all documented actions
Its configuration also changed recently in PR 352, and it can now be used like this:

      arch_contract_data:
        val:
          actions:
          - action: REMOVE_LINE
            where:
            - column: name
              regex: PurchasedLicenseInput\.bypassSysDate
            - column: name
              regex: PurchasedLicenseInput\.caseCounterStartDate
            - column: name
              regex: PurchasedLicenseInput\.description
            - column: name
              regex: PurchasedLicenseInput\.endDate
            - column: name
              regex: PurchasedLicenseInput\.name
            - column: name
              regex: PurchasedLicenseInput\.numberCases
            - etc. ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the configuration sample.
For the rest, how do we document it properly the where clause? How can it be used outside of arch_contract_data? Because it's mostly useful for this table because of the keys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbource i think it misse some words about maxSize defined by default to 512 as global option. The max size allow to truncate a big text. MasSize could be define also on each action. But it really use for KEEP and Replace.

@tbouffard tbouffard merged commit 65cbaa8 into main Jun 11, 2024
4 checks passed
@tbouffard tbouffard deleted the bpi_add_pi_cli_anon branch June 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants