Isolate path refactorings #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 09093a2.
robin-aws
reviewed
Oct 22, 2024
Comment on lines
-548
to
+546
| impl.Blocks.AddRange(implRefinementCheckingBlocks); | ||
| foreach (var block in implRefinementCheckingBlocks) { | ||
| impl.Blocks.Add(block); | ||
| } |
There was a problem hiding this comment.
AddRange does not exist on IList
There was a problem hiding this comment.
Ah damn, feels like a ripe opportunity for an extension method :P
Comment on lines
+12
to
+14
| [Rep] | ||
| [ElementsPeer] | ||
| public List<Cmd> /*!*/ Cmds; |
There was a problem hiding this comment.
Better because simpler? Technically we're losing the contract.
There was a problem hiding this comment.
TBH I don't value the nullability contracts. It would be simple to add them by adding #nullable enable
There was a problem hiding this comment.
Assuming this is only renaming and formatting?
There was a problem hiding this comment.
There's also conversion to a switch statement, and possibly other fully automated Rider refactorings such as invert if
robin-aws
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
No additional tests needed