Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicates in finds + work on unit tests + vendor cleanup #122

Merged
merged 4 commits into from
Apr 15, 2019

Conversation

grzkv
Copy link
Member

@grzkv grzkv commented Apr 14, 2019

This fixes #112 + see commit messages

@grzkv grzkv requested a review from a team April 14, 2019 20:52
@grzkv grzkv self-assigned this Apr 14, 2019
@codecov-io
Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #122 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   56.46%   56.48%   +0.02%     
==========================================
  Files          54       54              
  Lines        5683     5686       +3     
==========================================
+ Hits         3209     3212       +3     
  Misses       2264     2264              
  Partials      210      210
Impacted Files Coverage Δ
pkg/types/encoding/json/encoding.go 19.13% <100%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e165c...87ea9eb. Read the comment docs.

@grzkv grzkv merged commit 5bda037 into master Apr 15, 2019
@grzkv grzkv deleted the grzkv/no_duplicates_find_and_tests branch April 15, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants