Skip to content

Commit

Permalink
Update maintainer_checklist.md (ethereum-lists#6203)
Browse files Browse the repository at this point in the history
Co-authored-by: ligi <[email protected]>
  • Loading branch information
leopardracer and ligi authored Nov 19, 2024
1 parent e94b714 commit 6523d3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion maintainer_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ A checklist for things to check before merging a chain PR.
* If the PR contains icons:
* `ipfs get` all icon CIDs
* check if the size of the icons you got match the size given in the PR
* Check if a PR does not remove a chain - chains cannot be re-moved - only deprecated (to protect from replay attacks)
* Check if a PR does not remove a chain - chains cannot be removed - only deprecated (to protect from replay attacks)
* Check if a PR does not assign a chainID to a newer chain (something like https://github.com/ethereum-lists/chains/pull/1750)

If anyone has ideas on how to automate these things in CI - PRs welcome!

0 comments on commit 6523d3b

Please sign in to comment.