#254 Create schedule is adding it disabled and they are ran

[florentinvintila]

Closes #254

When scheduler is active create schedule is adding it disabled and they are ran.

[tlawrie]

Hey @florentinvintila can you clarify, do we want all schedules to be created active or just runonce schedules?

On line 207 we set the status to trigger_disabled... but the wrapping condition on 206 is that the trigger is enabled. Should we be removing line 207 and just set to active for all types?

[florentinvintila]

@tlawrie for this case setting all to enabled seems to be the solution. But I would like to understand what each status represents and for what they were intended to be used.

[tlawrie]

Hi @florentinvintila @AndreiOla this PR seems to have a whole number of commits pulled in which make it quite hard to review. Do you want to cherry pick the change over to a different branch? or undo some of the commits that have been pulled in that don't relate to the PR?

In terms of what is the check meant to be doing, I think it's actually the check that needs to be fixed...

Boolean enableJob = false;
          if (WorkflowScheduleStatus.active.equals(schedule.getStatus()) && wfEntity.getTriggers().getScheduler().getEnable()) {
            scheduleEntity.setStatus(WorkflowScheduleStatus.trigger_disabled);
            enableJob = true;
          }

In the above, I think the check for wfEntity.getTriggers().getScheduler().getEnable() should actually be not !wfEntity.getTriggers().getScheduler().getEnable() and therefore set to disabled status.

The reason I say that is

1. The ScheduleEntity is created with status to active. So setting it to active (as is the update in PR) doesn't really do anything.
2. The execution code is then meant to check on that status and not execute the schedule.

An alternate fix might be needed.

[tlawrie]

The solution may be

          Boolean enableJob = false;
          if (WorkflowScheduleStatus.active.equals(scheduleEntity.getStatus()) && wfEntity.getTriggers().getScheduler().getEnable()) {
            enableJob = true;
          } else if (WorkflowScheduleStatus.active.equals(scheduleEntity.getStatus()) && !wfEntity.getTriggers().getScheduler().getEnable()) {
            scheduleEntity.setStatus(WorkflowScheduleStatus.trigger_disabled);
          }

I can't test it as I am in the middle of v4 of Workflow

[tlawrie]

I added the code to this branch. Let me know if it works or not #261

[tlawrie]

hey @florentinvintila checking in on the above... if the solution on the proposed branch is good, we can open a second PR for the v4 branch as well.

[tlawrie]

Hi @florentinvintila @amhudson @gchickma checking in if the proposed fix #261 was a fix for this?

[amhudson]

Hi @florentinvintila @amhudson @gchickma checking in if the proposed fix #261 was a fix for this?

Looks to be

[tlawrie]

Hi @florentinvintila @amhudson @gchickma checking in if the proposed fix #261 was a fix for this?

Looks to be

Hi @amhudson so am I good to close this PR and merge in #261 ?

[amhudson]

@tlawrie I think so