Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…-recsys-01 into feat/3-basecode
feat: baseline code download & args.yaml로 config 관리하도록 변경 #3
* model이름_best_pt로 이름 변경 * wandb_runname_best_model.pt로 변경 * run_name값 수정 + trainer.run()의 인자로 추가 * 최신 파일로 + 이름 에러 * 시간 표현 - 없이 붙여서 바꾸고, yaml파일에서 모델 이름 바꾸면 다른 모델 이름으로 나옴 --------- Co-authored-by: Dongeun <[email protected]>
* ensemble 추가 * ensemble 수정 * Delete dkt/ensembles directory dkt 앙상블 삭제~~ * Delete dkt/ensemble.py --------- Co-authored-by: Dongeun <[email protected]>
* feat: lgbm을 학습하는데 사용하는 함수들 구현 #14 * feat: lgbm 하이퍼파라미터 설정 딕셔너리 구현 #14 * feat: 학습을 위한 seed 설정, log 설정 기능 구현 * feat: lgbm을 위한 arguments 정보를 설정하는 파일 추가 #14 * feat: lgbm학습을 위한 데이터처리를 하는 모듈 개발 #14 * feat: lgbm을 학습하고 추론해서 csv파일을 만드는 기능 구현 #14 * docs: lgbm 모델 학습에 필요한 라이브러리가 정리된 파일 작성 #14 * docs: lgbm 소스코드를 설명하는 파일 작성 #14 * feat: Feature Engineering을 위한 다양한 함수 구현 #14
* fix: attnlstm을 학습할 수 있도록 get_model 함수 수정 #21 * docs: 데이터 경로 수정 #21 * feat: attnlstm 모델 구현 #21 --------- Co-authored-by: 조성홍_T6165 <[email protected]>
Feat/2-cv
* feat: log values for lightgcn * Update sweep * fix typo and comment * fix comment * Update lightgcn for valid split * Update lightgcn for valid split
* saint * data 경로 바꿈 * Saint 모델 추가하기 * commit * conflict 해결 * saint,saint+추가 * 삭제 * 제출파일 * saint 모델 모두 추가 * yaml파일 다시 고치기 * model에서 saint 삭제 * 삭제 * saint model 불러오는 코드 수정 * submission 파일 이름 바꾸기 * 주석 수정 * 자잘히 수정 * submission 예시 * saint 모델 불러오는 것 추가, submission run_name 변경 * 길이 수정 * Delete dkt/outputs/saintplus-20240118004836-0_best_model_submission.csv * Delete dkt/outputs/submission.csv * Update args.yaml * Delete dkt/dkt/saintplus directory * Update trainer.py --------- Co-authored-by: Dongeun <[email protected]> Co-authored-by: Judy <[email protected]>
* feat: log values for lightgcn * Update sweep * fix typo and comment * fix comment * Update lightgcn for valid split * Update lightgcn for valid split * Update valid split * Update valid split (wrong) --------- Co-authored-by: Judy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @sangwoonoel @Lee-hyeonkyu @uhhyunjoo @GangBean @Dong-droid @twndus