[BE] 즐겨찾기, 마이페이지 API 수정 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuuo3o
approved these changes
Nov 26, 2024
| @@ -106,7 +107,7 @@ export class AssetService { | |||
| private async updateMyAsset(asset: Asset, currPrices) { | |||
| const userId = asset.user_id; | |||
| const userStocks = await this.userStockRepository.find({ | |||
| where: { user_id: userId }, | |||
| where: { user_id: userId, quantity: MoreThan(0) }, | |||
There was a problem hiding this comment.
🟢 여기 근데 보유량이 0인 경우는 뭔가요??
예를 들어 삼성전자 20주 구매했는데 20주 전부 매도하면 보유량이 0이 되는건가요?
만약에 그런거라면, 하루에 한번씩 장 마감 됐을 때 저런 거 delete 하는 로직도 추가되면 좋을 거 같아요!
There was a problem hiding this comment.
맞습니당! 그 로직도 추가하면 좋을 것 같네요ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업