Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 유저 닉네임 변경 API 추가 #223

Merged
merged 4 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions BE/src/auth/dto/rename-user.dto.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { ApiProperty } from '@nestjs/swagger';

export class RenameUserDto {
@ApiProperty({ description: '변경할 닉네임' })
nickname: string;
}
20 changes: 19 additions & 1 deletion BE/src/auth/user.controller.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { Controller, Get, Req, UseGuards } from '@nestjs/common';
import { Body, Controller, Get, Post, Req, UseGuards } from '@nestjs/common';
import { Request } from 'express';
import {
ApiBearerAuth,
ApiBody,
ApiOperation,
ApiResponse,
ApiTags,
} from '@nestjs/swagger';
import { UserService } from './user.service';
import { JwtAuthGuard } from './jwt-auth-guard';
import { ProfileResponseDto } from './dto/profile-response.dto';
import { RenameUserDto } from './dto/rename-user.dto';

@Controller('/api/user')
@ApiTags('프로필 API')
Expand All @@ -27,4 +29,20 @@ export class UserController {
getProfile(@Req() request: Request) {
return this.userService.getProfile(parseInt(request.user.userId, 10));
}

@Post('/rename')
@UseGuards(JwtAuthGuard)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 닉네임 수정은 patch 메소드가 더 낫지 않을까용...? 어떻게 생각하세요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 완전 좋아요 patch!!
맞아요.. 당연한건데.. 전체 수정이 아니라 부분 수정이니까!!
당장 반영하겠습니다.

@ApiOperation({
summary: '유저 닉네임 변경 API',
})
@ApiBody({
type: RenameUserDto,
})
@ApiBearerAuth()
renameUser(@Req() request: Request, @Body() body: RenameUserDto) {
const userId = parseInt(request.user.userId, 10);
const newName = body.nickname;

return this.userService.renameUser(userId, newName);
}
}
22 changes: 21 additions & 1 deletion BE/src/auth/user.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { Injectable } from '@nestjs/common';
import {
BadRequestException,
Injectable,
NotFoundException,
} from '@nestjs/common';
import { UserRepository } from './user.repository';
import { ProfileResponseDto } from './dto/profile-response.dto';

Expand All @@ -10,4 +14,20 @@ export class UserService {
const user = await this.userRepository.findOneBy({ id: userId });
return new ProfileResponseDto(user.nickname, user.email);
}

async renameUser(userId: number, newName: string) {
const user = await this.userRepository.findOneBy({ id: userId });
if (!user) {
throw new NotFoundException('존재하지 않는 유저입니다.');
}

const isDuplicated = await this.userRepository.findBy({
nickname: newName,
});
if (isDuplicated.length > 0) {
throw new BadRequestException('이미 존재하는 닉네임입니다.');
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 existsBy 이런거로 boolean 값 받아서 할 수도 있을 것 같아요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우..! 저도 저런 식으로만 했어서 생각도 못했네요 그런 메소드가 있었군요..! 감사합니다!

Copy link
Collaborator Author

@uuuo3o uuuo3o Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안그래도 boolean 으로 하고 싶었는데 저렇게 찾으니까 없는 경우에도 빈 배열이어서.. 뭐 어떤 상황에서도 다 true로 가지고 오더라구요..ㅋㅋㅋ
감사합니다!!!

return this.userRepository.update({ id: userId }, { nickname: newName });
}
}
Loading