[FE] 차트 고도화 & favicon & 화면 레이아웃 일부 수정. #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongree
reviewed
Nov 28, 2024
| padding, | ||
| 0.1, | ||
| ); | ||
| if (moveAverageToggle) { |
There was a problem hiding this comment.
이동 평균선 지웠다가 넣었다가하는 용도로 사용했습니다.
| @@ -2,7 +2,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | |||
| <link rel="icon" href="src/assets/favicon.ico" type="image/x-icon" /> | |||
There was a problem hiding this comment.
type="image/x-icon" 은 무엇을 의미하나요??
There was a problem hiding this comment.
vite에서 파비콘 설정할 때 아이콘 타입까지 넣어줄 용도로 넣었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
두 가지 PR 템플릿 중 하나를 골라 작성하시면 됩니다!
✅ 주요 작업
💭 고민과 해결과정
📊 FE/BE 전체 작업 내역