Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to_chars errc value for overflow #167

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix to_chars errc value for overflow #167

merged 2 commits into from
Feb 20, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Feb 20, 2024

Partially addresses: #166

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://167.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://167.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0e3d9cf) 92.30% compared to head (1a83f89) 92.30%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #167   +/-   ##
========================================
  Coverage    92.30%   92.30%           
========================================
  Files           64       64           
  Lines         8316     8316           
========================================
  Hits          7676     7676           
  Misses         640      640           
Files Coverage Δ
test/github_issue_152.cpp 98.78% <100.00%> (ø)
test/github_issue_152_float128.cpp 100.00% <ø> (ø)
test/to_chars.cpp 100.00% <100.00%> (ø)
...lude/boost/charconv/detail/dragonbox/dragonbox.hpp 97.38% <80.00%> (ø)
...lude/boost/charconv/detail/ryu/ryu_generic_128.hpp 83.62% <0.00%> (ø)
...de/boost/charconv/detail/to_chars_integer_impl.hpp 96.89% <25.00%> (ø)
include/boost/charconv/detail/dragonbox/floff.hpp 73.60% <50.00%> (ø)
src/to_chars.cpp 92.59% <16.66%> (ø)
src/to_chars_float_impl.hpp 79.55% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3d9cf...1a83f89. Read the comment docs.

@mborland mborland merged commit f5e1971 into develop Feb 20, 2024
58 of 59 checks passed
@mborland mborland deleted the 166 branch February 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants