Adds support for disconnected graphs to the sloan ordering algorithm #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sloan ordering algorithm before this patch could not handle disconnected graphs. We ran into this problem with the development of LTSmin and made this patch. This was already two years ago, but I figured it could still be valuable to someone else.
I am in no means an expert in the algorithm. The changes seem logical, but it would be good if someone with a better understanding of the algorithm would look at it.
The included test is a simple one, but fails before this patch: only one connected component is visited and node "3" is not considered at all. With the patch, both connected components are considered and the right ordering is achieved.
Please let me know if I need to change anything.