Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow extra members for converted structs #1056

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

allow extra members for converted structs #1056

wants to merge 4 commits into from
+221 −72

Conversation

grisumbras
Copy link
Member

Fix #991

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (b6c916f) to head (82ac926).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1056      +/-   ##
===========================================
+ Coverage    93.41%   93.66%   +0.24%     
===========================================
  Files           91       91              
  Lines         8667     9150     +483     
===========================================
+ Hits          8096     8570     +474     
- Misses         571      580       +9
Files with missing lines Coverage Δ
include/boost/json/detail/parse_into.hpp 100.00% <100.00%> (+0.25%) ⬆️
include/boost/json/detail/value_to.hpp 98.29% <100.00%> (-1.71%) ⬇️

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c916f...82ac926. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@grisumbras grisumbras force-pushed the feature/direct-struct-extra branch 2 times, most recently from 11f8035 to 533a570 Compare October 17, 2024 16:38
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@grisumbras grisumbras force-pushed the feature/direct-struct-extra branch 2 times, most recently from 2b758cc to 7038f99 Compare October 22, 2024 13:25
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1056.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1056/pullrequest.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow unknown described class members with a parse option
2 participants
@grisumbras @cppalliance-bot