Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for release notes asciidoc macros (#1082) #1377

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

daveoconnor
Copy link
Collaborator

@daveoconnor daveoconnor commented Oct 23, 2024

Related to ticket #1082, this adds support for asciidoc macros to emulate macros from qbk. The qbk items below are the originals from the ticket, the asciidoc items below are the new ones for asciidocs, and the html items below are the output.

qbk: [phrase library..XX]
String to use in asciidoc: phrase::[library,Hi!]
html: <span class="library">Hi!</span>

qbk: [@/libs/function/ Function]
asciidoc: at::/tools/build/doc/html/#_version_5_1_0[B2 version 5.1.0]
html: <a href="/tools/boost/boost_1_75_0/libs/algorithm/doc/html/algorithm/">Algorithm Library</a>

qbk: [github_pr geometry 1247]
asciidoc: github_pr::[geometry,1247]
html: <a href="https://github.com/boostorg/geometry/pull/1247">PR#1247</a>

qbk: [github geometry 1231]
aasciidoc: github_issue::[geometry,1231]
html: <a href="https://github.com/boostorg/geometry/issues/1231">#1231</a>

qbk: [phrase library..[@/libs/charconv/ Charconv]:]
asciidoc: phrase::[library,at::/libs/charconv/[Charconv:]]
html: <span class="library"><a href="/libs/charconv/">Charconv:</a></span>

@daveoconnor daveoconnor marked this pull request as ready for review October 23, 2024 00:26
@vinniefalco
Copy link
Member

These use asciidoctor's framework for authoring macros? Or is it just doing some kind of regex on the input file? I thought asciidoctor extensions had to be written in Ruby?

@grafikrobot
Copy link
Member

How are these asciidoctor macros without being written in Ruby? Also, they seem to be the wrong syntax for asciidoctor macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants