Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: more consistent messaging considering --repair, fixes #8533 #8601

Merged

Conversation

ThomasWaldmann
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (69151c7) to head (a6dc8c5).
Report is 3 commits behind head on 1.4-maint.

Files with missing lines Patch % Lines
src/borg/archive.py 46.15% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #8601      +/-   ##
=============================================
- Coverage      82.54%   82.47%   -0.07%     
=============================================
  Files             38       38              
  Lines          11096    11116      +20     
  Branches        1718     1725       +7     
=============================================
+ Hits            9159     9168       +9     
- Misses          1379     1387       +8     
- Partials         558      561       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann force-pushed the check-clarify-messages-1.4 branch from 633f95e to a6dc8c5 Compare December 26, 2024 17:39
@ThomasWaldmann ThomasWaldmann merged commit 6ccffe4 into borgbackup:1.4-maint Dec 28, 2024
10 of 12 checks passed
@ThomasWaldmann ThomasWaldmann deleted the check-clarify-messages-1.4 branch December 28, 2024 17:19
@ThomasWaldmann
Copy link
Member Author

Check the porting needs. As this is rather a clarification, maybe a port to 1.2-maint is not needed.

master code is likely very different, but could be inspected whether there are similar issues. In master, we do not have transactions anymore, so no "commit" there and thus quite different operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant