Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yes: deal with UnicodeDecodeError in input(), fixes #6984 #8612

Conversation

ThomasWaldmann
Copy link
Member

if retry is True, it will just retry to get a valid answer. if retry is False, it will return the default.

the code can be tested by entering "error" (without the quotes).

if retry is True, it will just retry to get a valid answer.
if retry is False, it will return the default.

the code can be tested by entering "error" (without the quotes).
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.82%. Comparing base (694fa93) to head (9d1107e).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/borg/helpers/yes_no.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8612      +/-   ##
==========================================
- Coverage   81.84%   81.82%   -0.03%     
==========================================
  Files          74       74              
  Lines       13311    13323      +12     
  Branches     1960     1963       +3     
==========================================
+ Hits        10894    10901       +7     
- Misses       1755     1758       +3     
- Partials      662      664       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit 35c56b9 into borgbackup:master Dec 29, 2024
14 of 16 checks passed
@ThomasWaldmann ThomasWaldmann deleted the yesno-ignore-unicode-error-master branch December 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant