Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup eigen svd clang warning. Update svd options usage. #2032

Closed
wants to merge 1 commit into from

Conversation

jmackay2
Copy link
Contributor

This removes the GCC diagnostic handling for svd by checking the svd info. This was made available in Eigen 3.4, which this repository uses.

This also updates a few of the JacobiSVD to use the templated options. This is the preferred method instead of passing it in as an argument, which will be deprecated in the future.

@dellaert
Copy link
Member

Cool! but still some Ci issue :-)

@dellaert
Copy link
Member

BTW, this might be an issue:

  • what version of Eigen do we bundle? Is it 3.4??
  • what “system Eigen” do we support? I think we should look at earliest supported a Ubuntu and see what it comes with.
    So, this PR might introduce incompatibilities.

@jmackay2 jmackay2 closed this Feb 25, 2025
@jmackay2 jmackay2 deleted the eigen_updates branch February 25, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants