fix: also use etag for private cache

born05 · Aug 13, 2024 · 4881784 · 4881784
1 parent eeacc42
commit 4881784
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/npm/index.ts b/npm/index.ts
@@ -24,7 +24,7 @@ const DEFAULT_HEADER_OPTIONS: HeaderOptions = {
   mustRevalidate: false,
   maxAge: 60,
   sMaxAge: null,
-  public: true,
+  public: false,
   private: false,
   noCache: false,
   etagCacheKey: 'cache-control-etag',
@@ -78,10 +78,7 @@ export async function createCacheControlResponse(
       (param) => !new URL(request.url).searchParams.has(param)
     )
   ) {
-    const allowPublicCaching =
-      options.public && !request.headers.has('Authorization');
-
-    if (allowPublicCaching && options.etagCacheKey && redis) {
+    if (options.etagCacheKey && redis) {
       const etag = await redis.get(options.etagCacheKey);
 
       if (etag) {
@@ -98,8 +95,11 @@ export async function createCacheControlResponse(
     }
 
     headers['Cache-Control'] = [
+      options.public &&
+        !request.headers.has('Authorization') &&
+        !options.private &&
+        'public',
       options.private && !options.public && 'private',
-      allowPublicCaching && !options.private && 'public',
       options.maxAge !== null && `max-age=${options.maxAge}`,
       options.sMaxAge !== null && `s-maxage=${options.sMaxAge}`,
       options.mustRevalidate && 'must-revalidate',

diff --git a/npm/package-lock.json b/npm/package-lock.json
diff --git a/npm/package.json b/npm/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@born05/sveltekit-cache-control",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "A simple way to add control caching in your SvelteKit project.",
   "main": "index.js",
   "scripts": {