Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support for raw data #89

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

fix: support for raw data #89

wants to merge 16 commits into from

Conversation

ZmRZjFuDsDiR4qi5801F
Copy link
Contributor

Bug 981245: node-red-contrib-ctrlx-automation: No support for RAW data

@ZmRZjFuDsDiR4qi5801F
Copy link
Contributor Author

@krauskopf : "skipped unittest 'ctrlx-datalayer-subscribe: Error Handling', please adapt to new behaviour and enable again.

@ZmRZjFuDsDiR4qi5801F
Copy link
Contributor Author

ZmRZjFuDsDiR4qi5801F commented Jan 23, 2025 •
edited
Loading

changed: the nodes now return the data as-it-is with type 'raw', if not valid JSON (server failure or raw data)

@krauskopf krauskopf self-requested a review January 23, 2025 15:43
@krauskopf
Copy link
Contributor

I am missing a comment in the changelog of the readme.md

@ZmRZjFuDsDiR4qi5801F
Copy link
Contributor Author

@krauskopf: using default VS Code formatting, so please adopt or "hide white space"

@krauskopf
Copy link
Contributor

@krauskopf: using default VS Code formatting, so please adopt or "hide white space"

Can you make your VSCode config to consider the .editorconfig settings?
https://github.com/boschrexroth/node-red-contrib-ctrlx-automation/blob/master/.editorconfig

@ZmRZjFuDsDiR4qi5801F
Copy link
Contributor Author

ZmRZjFuDsDiR4qi5801F commented Jan 27, 2025 •
edited
Loading

@krauskopf : It's not the .editorconfig, it's your used formatting extension which differs from current default one and Prettier, maybe you're using a deprecated one. I tried to restore the previous formatting, but please think about to update. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krauskopf krauskopf Awaiting requested review from krauskopf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZmRZjFuDsDiR4qi5801F @krauskopf