Add newlines between functions in translate.go

[Neved4]

Fixes #26

Chose a strategy to add newlines between functions, while ensuring no newline is added on the last one.

   1   #!/bin/sh
   2   function f
   3     echo 'This is the f function'
   4   end
   5   
   6   function g
   7     echo 'This is the g function'
   8   end
   9   
  10   function h
  11     echo 'This is the h function'
  12   end

[JoaoCostaIFG]

Hi @Neved4!
Looks good to me, but needs to update the tests. I've generated the following patch if you want to apply it:

function_newline_tests.patch.txt

[Neved4]

Done!

[bouk]

Could you change this to use the Stmt Pos and End methods to determine whether the original code had an extra newline: https://pkg.go.dev/mvdan.cc/sh/v3/syntax#Stmt.End

Then we can make it actually whitespace preserving 🙂

[Neved4]

@bouk Sounds great! Wasn't familiar with mvdan/sh internals

Pushed two commits, please lmk if that's how you intended it, it's my first time with parsers

Cheers!

[bouk]

You'll just have to update the test now, but looks good!

[Neved4]

Even if b15c764 is simpler, it adds extra newlines between commands. To minimize changes to the current tests and output, I reverted it in favor of 915fb09. Updated tests accordingly.

If you need anything else, just give me a shout, cheers!

[bouk]

thx!