Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 95: Interactors #108

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Issue 95: Interactors #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/controllers/volunteers_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,7 @@ def knight
end

volunteer = Volunteer.find(params[:volunteer_id])
Copy link
Contributor Author

@jconley88 jconley88 Mar 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this find here in case we wanted to apply the pattern here and act on both a Volunteer and Assignment.

If not, I'll pull this down into Knight.

Copy link
Member

@ericfreese ericfreese Mar 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think the difference between these is that this one makes the volunteer a "super admin" whereas the one in assignments_controller makes the volunteer a "region admin".

As far as authorization goes, there's basically 3 roles a user can be: super admin, region admin, or regular volunteer:

  • Volunteers are assigned to a region, and can only do certain things in that region.
  • Region admins can do everything a regular volunteer can do but can do more things than regular volunteers in the regions they are assigned to.
  • Super admins can do everything regular volunteers can do and everything region admins can do (for all regions), plus some other stuff.

What would you think of renaming this interactor to something like ToggleSuperAdmin? Then we could create a separate interactor for AssignmentsController#knight named something like ToggleRegionAdmin?

I think it's still fine to have it take an ActiveRecord object (Volunteer) instead of an id though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down with that!

volunteer.admin = !volunteer.admin
if volunteer.save
if ToggleSuperAdmin.call(volunteer: volunteer).success?
flash[:notice] = "#{volunteer.name} Updated to Admin: #{volunteer.admin}"
else
flash[:error] = "#{volunteer.errors.full_messages}"
Expand Down
12 changes: 12 additions & 0 deletions app/interactors/toggle_super_admin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
class ToggleSuperAdmin
include Interactor

delegate :volunteer,
:fail!,
to: :context

def call
volunteer.admin = !volunteer.admin
fail! unless volunteer.save
end
end
42 changes: 42 additions & 0 deletions spec/interactors/toggle_super_admin_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
require 'rails_helper'

RSpec.describe ToggleSuperAdmin do
describe '::call' do
let(:volunteer) do
create(:volunteer)
end

subject do
described_class.call(
volunteer: volunteer
)
end

it 'fails if it cannot save the volunteer' do
expect(volunteer).to receive(:save).and_return false
expect(subject.success?).to eq(false)
end

context 'is admin' do
let(:volunteer) do
create(:volunteer, admin: true)
end

it 'unsets the admin flag' do
expect(subject.success?).to eq(true)
expect(volunteer.reload.admin).to eq(false)
end
end

context 'is not admin' do
let(:volunteer) do
create(:volunteer, admin: false)
end

it 'sets the admin flag' do
expect(subject.success?).to eq(true)
expect(volunteer.reload.admin).to eq(true)
end
end
end
end