Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add number of respondents #142

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

Jone-Torgersen
Copy link
Contributor

@Jone-Torgersen Jone-Torgersen commented Jan 28, 2025

Description

  • Updated questionResponsedto to include numberOfRespondents
  • Updated surveyDto to include totalParticipants
  • added totalParticipants to survey model
  • added numberOfRespondents to Answer model
  • Updated flow to pass down numberOfRespondents to chart counter component
  • Updated counter component to get total from survey object

Testing Done

Type of change

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to break)
  • Documentation update required for this change

Checklist:

  • My code adheres to the style guidelines of this project
  • I have performed a self-review of my code
  • I have added comments to my code, especially in complex areas
  • I have updated the documentation accordingly
  • My changes do not introduce any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my feature
  • Both new and existing unit tests pass locally with my changes
  • I have considered and addressed any potential security implications

- Updated questionResponsedto to include numberOfRespondents
- Updated surveyDto to include totalParticipants
- added totalParticipants to survey model
- added numberOfRespondents to Answer model
- Updated flow to pass down numberOfRespondents to chart counter component
- Updated counter component to get total from survey object
@Jone-Torgersen Jone-Torgersen merged commit 430d2c3 into main Jan 28, 2025
1 check passed
@Jone-Torgersen Jone-Torgersen deleted the feat/add-number-of-respondents branch January 28, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants