Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support sign template and new sign status #1197

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat: Support sign template and new sign status #1197

merged 5 commits into from
Aug 29, 2023

Conversation

congminh1254
Copy link
Member

Closes: SDK-3264

@coveralls
Copy link

coveralls commented Aug 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #3217

  • 119 of 180 (66.11%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.366%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSignRequestCreateParams.java 3 4 75.0%
src/main/java/com/box/sdk/BoxSignRequest.java 9 19 47.37%
src/main/java/com/box/sdk/BoxSignTemplate.java 107 157 68.15%
Totals Coverage Status
Change from base Build #3188: 0.04%
Covered Lines: 7275
Relevant Lines: 10194
💛 - Coveralls

@congminh1254 congminh1254 merged commit e37c0dc into main Aug 29, 2023
9 checks passed
@congminh1254 congminh1254 deleted the support-sign-template branch August 29, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszsocha2 lukaszsocha2 lukaszsocha2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @lukaszsocha2