Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add iframeable_embed_url field to BoxSignRequestSigner class #1202

Merged
merged 1 commit into from
Sep 12, 2023
Merged

feat: Add iframeable_embed_url field to BoxSignRequestSigner class #1202

merged 1 commit into from
Sep 12, 2023

Conversation

lukaszsocha2
Copy link
Contributor

Closes: SDK-3318

@coveralls
Copy link

coveralls commented Sep 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #3247

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.008%) to 71.38%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxSignRequestSigner.java 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/BoxFileUploadSession.java 1 64.67%
src/main/java/com/box/sdk/EventStream.java 1 87.5%
src/main/java/com/box/sdk/MetadataQuery.java 1 92.59%
Totals Coverage Status
Change from base Build #3230: 0.008%
Covered Lines: 7280
Relevant Lines: 10199
💛 - Coveralls

arjankowski
arjankowski approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszsocha2 lukaszsocha2 merged commit 2e931d8 into main Sep 12, 2023
8 of 9 checks passed
@lukaszsocha2 lukaszsocha2 deleted the sdk-3318-add-field-to-sign-request branch September 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszsocha2 @coveralls @arjankowski