Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix not closing response body #1208

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: fix not closing response body #1208

merged 2 commits into from
Sep 26, 2023

Conversation

lukaszsocha2
Copy link
Contributor

No description provided.

@lukaszsocha2 lukaszsocha2 force-pushed the fix-not-closing-response-body-error branch from eae19af to 359f8d6 Compare September 26, 2023 13:33
@lukaszsocha2 lukaszsocha2 force-pushed the fix-not-closing-response-body-error branch from 359f8d6 to 0704d13 Compare September 26, 2023 13:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build #3320

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 71.563%
Totals Coverage Status
Change from base Build #3308: 0.005%
Covered Lines: 7429
Relevant Lines: 10381
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #3336

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 71.539%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3326: 0.003%
Covered Lines: 7435
Relevant Lines: 10393
💛 - Coveralls

@lukaszsocha2 lukaszsocha2 changed the title [WIP] fix not closing response body fix: fix not closing response body Sep 26, 2023
antusus
antusus approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@lukaszsocha2 lukaszsocha2 merged commit ab5e170 into main Sep 26, 2023
8 of 9 checks passed
@lukaszsocha2 lukaszsocha2 deleted the fix-not-closing-response-body-error branch September 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwwoda mwwoda mwwoda approved these changes

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukaszsocha2 @coveralls @antusus @mwwoda