Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing fields when update classification template #1255

Merged
merged 7 commits into from
Jun 21, 2024
Merged

fix: Add missing fields when update classification template #1255

merged 7 commits into from
Jun 21, 2024

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Jun 19, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3850

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3847

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3849

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3848

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3851

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3852

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@arjankowski
Copy link
Contributor

The code looks 👍
Have you thought about adding an integration test for this?

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3853

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3855

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3857

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3856

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3854

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3858

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3860

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3861

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3864

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3859

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3863

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3862

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3865

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3867

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3869

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3868

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3870

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3866

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3871

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3874

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3872

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3875

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #3876

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 72.166%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7672
Relevant Lines: 10631
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build #3873

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build #3873

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build #3873

Details

  • 31 of 35 (88.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/RealtimeServerConnection.java 1 77.78%
Totals Coverage Status
Change from base Build #3841: 0.05%
Covered Lines: 7666
Relevant Lines: 10623
💛 - Coveralls

@congminh1254 congminh1254 merged commit f17f817 into main Jun 21, 2024
12 checks passed
@congminh1254 congminh1254 deleted the classification-fields branch June 21, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congminh1254 @coveralls @arjankowski