Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: BoxCLI major version 4.0.0 #538

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat!: BoxCLI major version 4.0.0 #538

wants to merge 19 commits into from

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Jul 9, 2024

Todo: Change the build env to Node 16+

@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 11402365762

Details

  • 36 of 106 (33.96%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.5%) to 85.113%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/token-cache.js 0 12 0.0%
src/box-command.js 36 94 38.3%
Files with Coverage Reduction New Missed Lines %
src/token-cache.js 1 15.15%
Totals Coverage Status
Change from base Build 10902826551: -1.5%
Covered Lines: 4314
Relevant Lines: 4888

💛 - Coveralls

Copy link
Contributor

@mwwoda mwwoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this PR to breaking-changes branch instead as we will ship more breaking changes here

@@ -68,7 +69,7 @@
"standard-version": "^9.5.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump straight to 18

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
Copy link

stale bot commented Aug 25, 2024

This issue has been automatically marked as stale because it has not been updated in the last 30 days. It will be closed if no further activity occurs within the next 7 days. Feel free to reach out or mention Box SDK team member for further help and resources if they are needed.

@stale stale bot added the stale label Aug 25, 2024
Copy link

stale bot commented Sep 1, 2024

This issue has been automatically closed due to maximum period of being stale. Thank you for your contribution to Box CLI and feel free to open another PR/issue at any time.

@stale stale bot closed this Sep 1, 2024
@congminh1254 congminh1254 reopened this Oct 18, 2024
@congminh1254 congminh1254 reopened this Oct 18, 2024
@stale stale bot removed the stale label Oct 18, 2024
@congminh1254 congminh1254 changed the title feat: Support Box AI endpoints feat!: BoxCLI major version 4.0.0 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants