-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dropdown for selecting the page size on the workbench #1002
Conversation
mensinda
commented
Feb 29, 2024
31dfb92
to
3262fb5
Compare
@aurambaj How about "Page size: 100"? |
7865525
to
4ef0cbd
Compare
Rebased, and I switched the english text to "Page size". However, I would like to keep the german translation, because "Seitengröße" sounds weird. |
Daniel, Box has all the translations for mojito in (surprise!) an internal instance of mojito. I'll add this translation manually. @aurambaj What do you think of this idea? We can make a drop from this instance and share it publically on Box and then solicit volunteers to help us translate it? |
Since this is a JS only change, I would say that the CI error seems unrelated |
4ef0cbd
to
cf64bdf
Compare
@mensinda did contribute translations manually to the German file. Typically, we should not edit the properties file by hand but we don't have a public instance of Mojito where people could collaborate / update strings. We can always re-import the current properties files into a Mojito instance, there is a command for that. @ehoogerbeets when you say add "this manually" you mean generating a PR from the Box Mojito instance that contains update properties files? Is Box still translating new incoming strings or are the translation available only for older strings? There used to be a bot pushing new translation but last commit if from 5 years ago. To have volunteer help translate, we'd need some public instance running. Drop could work or we just re-create the project from the properties files. |
The "bot" is still there but hasn't been operating for a number of years as we are not sending the strings to our vendor. It could be resurrected again though, if for nothing else to make sure that the properties files for the other languages have the same entries as the English one does. As you say, we would have to re-import the current properties files into mojito in order to preserve the translations already contributed by the open-source community. |