Skip to content

Commit

Permalink
attempt to work around error loading plugin into media control
Browse files Browse the repository at this point in the history
  • Loading branch information
bikegriffith committed May 21, 2021
1 parent 19ae8c8 commit 41d7709
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 10 deletions.
4 changes: 2 additions & 2 deletions lib/clappr-chromecast-plugin.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/clappr-chromecast-plugin.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/clappr-chromecast-plugin.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/clappr-chromecast-plugin.min.js.map

Large diffs are not rendered by default.

22 changes: 22 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,13 @@
"sass-loader": "^8.0",
"stylelint": "^13.2",
"stylelint-config-recommended": "^3.0",
"svg-inline-loader": "^0.8.2",
"terser-webpack-plugin": "^2.3",
"webpack": "^4.0",
"webpack-cli": "^3.3",
"webpack-dev-server": "^3.10"
},
"dependencies": {
"lodash.assign": "^4.2.0"
}
}
2 changes: 1 addition & 1 deletion src/chromecast.js
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ export default class ChromecastPlugin extends UICorePlugin {

render() {
this.session ? this.renderConnected() : this.renderDisconnected()
this.core.mediaControl.$el.find('.media-control-right-panel[data-media-control]').append(this.$el)
this.core.mediaControl.$el.find('.media-control-right-panel').append(this.el)
this.$style && this.$style.remove()
this.$style = Styler.getStyleFor(chromecastStyle, {baseUrl: this.core.options.baseUrl})
this.core.$el.append(this.$style)
Expand Down
8 changes: 4 additions & 4 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ if (process.env.npm_lifecycle_event === 'dist') {
}

module.exports = {
entry: path.resolve(__dirname, 'src/chromecast.js'),
entry: path.resolve(__dirname, 'src/chromecast.js'), // eslint-disable-line
devtool: 'source-map',
optimization: optimization,
output: {
path: path.resolve(__dirname, 'lib'),
path: path.resolve(__dirname, 'lib'), // eslint-disable-line
filename: outputFile,
library: 'ChromecastPlugin',
libraryExport: 'default',
Expand All @@ -36,7 +36,7 @@ module.exports = {
loader: 'babel-loader'
},
include: [
path.resolve(__dirname, 'src')
path.resolve(__dirname, 'src') // eslint-disable-line
],
},
{
Expand Down Expand Up @@ -78,7 +78,7 @@ module.exports = {
},
devServer: {
contentBase: [
path.resolve(__dirname, 'public'),
path.resolve(__dirname, 'public'), // eslint-disable-line
],
// publicPath: '/js/',
disableHostCheck: true, // https://github.com/webpack/webpack-dev-server/issues/882
Expand Down

0 comments on commit 41d7709

Please sign in to comment.