Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation to bulk enable standard products #1953

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Feb 4, 2025

  • new mutation enableStandardProducts
  • new field Product.standardProduct

@pylipp
Copy link
Contributor Author

pylipp commented Feb 4, 2025

@pylipp pylipp marked this pull request as ready for review February 4, 2025 16:54
@pylipp pylipp requested a review from HaGuesto February 4, 2025 17:41
Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review passed

functional review passed

"""
Utility response type for standard product bulk-enable mutations, containing both enabled standard product instantiations and IDs of invalid standard products.
"""
type ProductsResult {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StandardProductsResult please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately can't use this name because it's the return type of the standardProducts query already.

@pylipp pylipp force-pushed the mutation-to-bulk-enable-standard-products branch from ccc75a8 to 10da00a Compare February 6, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants