rename bundle containerfile to Containerfile.bundle to be consistent #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 28.13% 28.13%
=======================================
Files 128 128
Lines 11209 11209
=======================================
Hits 3154 3154
Misses 7773 7773
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
msherif1234
force-pushed
the
upstream-bundle-containerfile
branch
from
353065a to
dd68077
Compare
…n the repo Signed-off-by: Mohamed Mahmoud <[email protected]>
msherif1234
force-pushed
the
upstream-bundle-containerfile
branch
from
dd68077 to
6a69083
Compare
msherif1234
changed the title
|
Do you need to update Container.bundle.openshift with sdk 1.27.0? |
probably at some point but not urgent |
Billy99
added a commit
to Billy99/bpfman-operator
that referenced
this pull request
Feb 18, 2025
bpfman#378 renamed bundle.Dockerfile as Containerfile.bundle to be consistent with other Containerfiles in the repository. However, bundle.Dockerfile is an autogenerate file that is generated during the `make bundle` command. So revert the rename and leave it as it was. Signed-off-by: Billy McFall <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename bundle container file to be consistent with other container files in the repo