Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(README): fix Camunda properties docs #1008

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(README): fix Camunda properties docs #1008

merged 1 commit into from
Dec 20, 2023
+12 −14

Conversation

philippfromme
Copy link
Contributor

Closes #1001

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 20, 2023
nikku
nikku reviewed Dec 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
nikku
nikku reviewed Dec 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
nikku
nikku reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added two minor suggestions (let's remove cloud where we can).

@philippfromme
Copy link
Contributor Author

Looks good. I added two minor suggestions (let's remove cloud where we can).

Changed the naming. Those cloud and platform names are going to haunt us for a long time.

@philippfromme philippfromme requested a review from nikku December 20, 2023 13:06
@nikku nikku merged commit f408e68 into main Dec 20, 2023
7 checks passed
@nikku nikku deleted the docs branch December 20, 2023 14:08
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@smbea smbea Awaiting requested review from smbea

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Camunda Property Integration
2 participants
@philippfromme @nikku