Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties Panel Header Displays Element Template Icon Found in XML #1012

Closed
wants to merge 9 commits into from
Closed

Properties Panel Header Displays Element Template Icon Found in XML #1012

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0af8856
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
01c0c76
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
226bb12
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
decb8a6
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
5096d84
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
6f99b9e
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
75bd12a
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
926e308
feat: modify panel header icon render, to make it consistent with ele…
Jan 4, 2024
559a5da
feat: modify panel header icon render, to make it consistent with ele…
Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/render/PanelHeaderProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,10 @@ export const PanelHeaderProvider = {
getElementIcon: (element) => {
const concreteType = getConcreteType(element);

const elementTemplates = getTemplatesService();
const templateIcon = getModelerTemplateIcon(element);

if (elementTemplates) {
const template = getTemplate(element, elementTemplates);

if (template && template.icon) {
return () => <img class="bio-properties-panel-header-template-icon" width="32" height="32" src={ template.icon.contents } />;
}
if (templateIcon) {
return () => <img class="bio-properties-panel-header-template-icon" width="32" height="32" src={ templateIcon } />;
}

return iconsByType[ concreteType ];
Expand Down Expand Up @@ -191,4 +187,12 @@ function getTemplateDocumentation(element, elementTemplates) {
const template = getTemplate(element, elementTemplates);

return template && template.documentationRef;
}

function getModelerTemplateIcon(element) {
// eslint-disable-next-line react-hooks/rules-of-hooks
const config = useService('config.elementTemplateIconRenderer', false);
const { iconProperty = 'zeebe:modelerTemplateIcon' } = config || {};
philippfromme marked this conversation as resolved.
Show resolved Hide resolved

return getBusinessObject(element).get(iconProperty);
}
Loading