feat: support editing zeebe:priorityDefinition
#1072
Conversation
Related to #1069
Skaiir
requested review from
a team,
philippfromme and
abdul99ahad
and removed request for
a team
Skaiir
changed the title
zeebe:priorityDefinitionzeebe:priorityDefinition
|
Thanks for the contribution @Skaiir! Will have a look! 🫶 |
| commandStack.execute('properties-panel.multi-command-executor', commands); | ||
| }; | ||
|
|
||
| const tooltip = <div> |
There was a problem hiding this comment.
We keep the tooltips in the respective provider. Also, the link doesn't point anywhere at the moment. I guess that's because the documentation doesn't exist yet?
There was a problem hiding this comment.
Hey there, yeah it's because it doesn't exist yet. Raised a follow-up here: #1073.
There was a problem hiding this comment.
On a related topic, there will come a time where this method of translating won't be enough. Not being able to move divs around relative to each-other prevents things like links or formatting inside of sentences. And the more different from English the languages become, the more formatting quirks will need to be involved.
I think something similar to the Trans component of react-i18next might make sense. Just floating the idea around.
There was a problem hiding this comment.
I think something similar to the Trans component of react-i18next might make sense. Just floating the idea around.
Let's keep things simple and not over-engineer. Quoting from the site you mentioned:
bpmn-io-tasks
bot
added
in progress
Skaiir
force-pushed
the
1069-support-priority-editing
branch
from
4c4c00f
to
2dab16b
Compare
|
Made the adjustments, removed the link entirely for now, follow up here: #1073. |
bpmn-io-tasks
bot
added
needs review
Proposed Changes
Adds an entry in the properties panel to edit the
zeebe:priorityDefinition::priorityof a user task. Should have a tooltip with some info and a (currently empty) link to docs.Closes #1069
npx @bpmn-io/sr bpmn-io/bpmn-js#main -l bpmn-io/bpmn-js-properties-panel#1069-support-priority-editing