Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy check #1089

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore: remove legacy check #1089

merged 1 commit into from
Nov 8, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Nov 8, 2024

We don't need it since we require more
recent diagram-js version.

Proposed Changes

This removes the ID check for implicit root which was required prior to [email protected]

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

We don't need it since we require more
recent diagram-js version.
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 8, 2024
@barmac barmac requested review from a team, abdul99ahad, misiekhardcore and nikku and removed request for a team November 8, 2024 08:02
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer dependencies (>= diagram-js@11) reflect this ✔️

@nikku nikku merged commit 2c91cbe into main Nov 8, 2024
10 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 8, 2024
@nikku nikku deleted the remove-legacy-check branch November 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants