Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make properties panel container focusable #1095

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

jarekdanielak
Copy link
Contributor

Related to https://github.com/bpmn-io/internal-docs/issues/1081

Proposed Changes

By making properties panel container focusable, user can click somewhere in the container (not only on buttons and inputs) to continue using keyboard shortcuts in the context of the panel.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Let us also port this to the DMN properties panel.

@jarekdanielak jarekdanielak merged commit ed9659b into main Nov 20, 2024
10 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 20, 2024
@jarekdanielak jarekdanielak deleted the tabindex branch November 20, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants