Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky list headers #1108

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Sticky list headers #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/provider/camunda-platform/properties/FormField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,24 @@ export default function FormField(props) {
id: idPrefix + '-formFieldValues',
component: ValueList,
formField,
idPrefix
idPrefix,
headerNestingLevel: 1,
});
}

entries.push({
id: idPrefix + '-formFieldConstraints',
component: ConstraintList,
formField,
idPrefix
idPrefix,
headerNestingLevel: 1
},
{
id: idPrefix + '-formFieldProperties',
component: PropertiesList,
formField,
idPrefix
idPrefix,
headerNestingLevel: 1
});

return entries;
Expand Down Expand Up @@ -321,7 +324,8 @@ function ValueList(props) {
const {
element,
formField,
idPrefix
idPrefix,
headerNestingLevel
} = props;

const id = `${ idPrefix }-formFieldValues`;
Expand Down Expand Up @@ -368,6 +372,7 @@ function ValueList(props) {
component={ Value }
onAdd={ addValue }
onRemove={ removeValue }
headerNestingLevel={ headerNestingLevel }
/>;
}

Expand Down Expand Up @@ -403,7 +408,8 @@ function ConstraintList(props) {
const {
element,
formField,
idPrefix
idPrefix,
headerNestingLevel
} = props;

const id = `${ idPrefix }-formFieldConstraints`;
Expand Down Expand Up @@ -482,7 +488,9 @@ function ConstraintList(props) {
items={ constraints }
component={ Constraint }
onAdd={ addConstraint }
onRemove={ removeConstraint } />
onRemove={ removeConstraint }
headerNestingLevel={ headerNestingLevel }
/>
);
}

Expand Down Expand Up @@ -518,7 +526,8 @@ function PropertiesList(props) {
const {
element,
formField,
idPrefix
idPrefix,
headerNestingLevel
} = props;

const id = `${ idPrefix }-formFieldProperties`;
Expand Down Expand Up @@ -597,5 +606,6 @@ function PropertiesList(props) {
component={ Property }
onAdd={ addProperty }
onRemove={ removeProperty }
headerNestingLevel={ headerNestingLevel }
/>;
}
6 changes: 4 additions & 2 deletions src/provider/camunda-platform/properties/InputOutputParameter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ export default function InputOutputParameter(props) {
id: `${idPrefix}-list`,
component: ListProps,
idPrefix,
parameter
parameter,
headerNestingLevel: 1
});

// (4) Map
Expand All @@ -102,7 +103,8 @@ export default function InputOutputParameter(props) {
id: `${idPrefix}-map`,
component: MapProps,
idPrefix,
parameter
parameter,
headerNestingLevel: 1
});
}

Expand Down
6 changes: 4 additions & 2 deletions src/provider/camunda-platform/properties/ListProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export function ListProps(props) {
const {
idPrefix,
element,
parameter
parameter,
headerNestingLevel
} = props;

const bpmnFactory = useService('bpmnFactory');
Expand Down Expand Up @@ -78,7 +79,8 @@ export function ListProps(props) {
label: translate('List values'),
onAdd: addItem,
onRemove: removeItem,
component: ListProp
component: ListProp,
headerNestingLevel
});
}

Expand Down
10 changes: 7 additions & 3 deletions src/provider/camunda-platform/properties/ListenerProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ function ExecutionListener(props) {
{
id: `${idPrefix}-fields`,
component: Fields,
listener
listener,
headerNestingLevel: 1
} ];
}

Expand Down Expand Up @@ -227,7 +228,8 @@ function TaskListener(props) {
{
id: `${idPrefix}-fields`,
component: Fields,
listener
listener,
headerNestingLevel: 1
} ];
}

Expand Down Expand Up @@ -434,7 +436,8 @@ function Fields(props) {
const {
id,
element,
listener
listener,
headerNestingLevel
} = props;

const bpmnFactory = useService('bpmnFactory');
Expand Down Expand Up @@ -474,6 +477,7 @@ function Fields(props) {
onAdd={ addField }
onRemove={ removeField }
autoFocusEntry={ `[data-entry-id="${id}-field-${fields.length - 1}"] input` }
headerNestingLevel={ headerNestingLevel }
/>;
}

Expand Down
4 changes: 3 additions & 1 deletion src/provider/camunda-platform/properties/MapProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export function MapProps(props) {
const {
idPrefix,
element,
parameter
parameter,
headerNestingLevel
} = props;

const bpmnFactory = useService('bpmnFactory');
Expand Down Expand Up @@ -88,6 +89,7 @@ export function MapProps(props) {
onAdd: addEntry,
onRemove: removeEntry,
component: MapProp,
headerNestingLevel
});
}

Expand Down